Require warnings to silence byte compilation warnings#712
Merged
Conversation
matsl
force-pushed
the
fix-warnings-for-unused-lexical-variable
branch
from
dd89d9f to
a43a82c
Compare
rswgnu
approved these changes
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Require warnings to get the definition of variables in the package.
Why
The variables
warning-minimum-levelandwarning-suppress-log-typesare not autoloaded. So not seen when byte compiling. By requiring
'warnings the variables are defined.
We could defvar them but requiring warnings cause no risk of circular
dependencies so is the preferred way to resolve this, IMHO.